Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: add burst randomization helpers

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jul 2 13:19:15 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14648 )

Change subject: trx_toolkit/data_msg.py: add burst randomization helpers
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14648/1/src/target/trx_toolkit/data_msg.py 
File src/target/trx_toolkit/data_msg.py:

https://gerrit.osmocom.org/#/c/14648/1/src/target/trx_toolkit/data_msg.py@500 
PS1, Line 500: 			sbit = random.randint(-127, 127)
> Shouldn't this be encoded 254.. […]
Nope, because this is an abstract representation. "On the wire" they're encoded as 254..0. See self.gen_burst() and self.parse_burst() above.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14648
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Idf1393d3d1f04e6c60b356b797a18e6f77b23554
Gerrit-Change-Number: 14648
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Jul 2019 13:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190702/c5af63c7/attachment.html>


More information about the gerrit-log mailing list