<p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14648">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14648/1/src/target/trx_toolkit/data_msg.py">File src/target/trx_toolkit/data_msg.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14648/1/src/target/trx_toolkit/data_msg.py@500">Patch Set #1, Line 500:</a> <code style="font-family:monospace,monospace">                      sbit = random.randint(-127, 127)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Shouldn't this be encoded 254.. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nope, because this is an abstract representation. "On the wire" they're encoded as 254..0. See self.gen_burst() and self.parse_burst() above.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14648">change 14648</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/14648"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idf1393d3d1f04e6c60b356b797a18e6f77b23554 </div>
<div style="display:none"> Gerrit-Change-Number: 14648 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 02 Jul 2019 13:19:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>