Change in ...osmocom-bb[master]: trxcon/scheduler: enrich GSM 05.03 encoding error messages

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jul 1 08:31:34 UTC 2019


fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14637 )

Change subject: trxcon/scheduler: enrich GSM 05.03 encoding error messages
......................................................................

trxcon/scheduler: enrich GSM 05.03 encoding error messages

Change-Id: I35a7c5df4fc0ed2195ba721f92812874011459d9
---
M src/host/trxcon/sched_lchan_pdtch.c
M src/host/trxcon/sched_lchan_rach.c
M src/host/trxcon/sched_lchan_tchf.c
M src/host/trxcon/sched_lchan_tchh.c
M src/host/trxcon/sched_lchan_xcch.c
5 files changed, 16 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/host/trxcon/sched_lchan_pdtch.c b/src/host/trxcon/sched_lchan_pdtch.c
index 845ef64..ad021a9 100644
--- a/src/host/trxcon/sched_lchan_pdtch.c
+++ b/src/host/trxcon/sched_lchan_pdtch.c
@@ -146,7 +146,9 @@
 	rc = gsm0503_pdtch_encode(buffer, lchan->prim->payload,
 		lchan->prim->payload_len);
 	if (rc) {
-		LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n");
+		LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n",
+		     lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload,
+							    lchan->prim->payload_len));
 
 		/* Forget this primitive */
 		sched_prim_drop(lchan);
diff --git a/src/host/trxcon/sched_lchan_rach.c b/src/host/trxcon/sched_lchan_rach.c
index e96a0e6..5d1f3ab 100644
--- a/src/host/trxcon/sched_lchan_rach.c
+++ b/src/host/trxcon/sched_lchan_rach.c
@@ -108,7 +108,8 @@
 		/* Encode extended (11-bit) payload */
 		rc = gsm0503_rach_ext_encode(payload, ext_req->ra11, trx->bsic, true);
 		if (rc) {
-			LOGP(DSCHD, LOGL_ERROR, "Could not encode extended RACH burst\n");
+			LOGP(DSCHD, LOGL_ERROR, "Could not encode extended RACH burst "
+						"(ra=%u bsic=%u)\n", ext_req->ra11, trx->bsic);
 
 			/* Forget this primitive */
 			sched_prim_drop(lchan);
@@ -125,7 +126,8 @@
 		/* Encode regular (8-bit) payload */
 		rc = gsm0503_rach_ext_encode(payload, req->ra, trx->bsic, false);
 		if (rc) {
-			LOGP(DSCHD, LOGL_ERROR, "Could not encode RACH burst\n");
+			LOGP(DSCHD, LOGL_ERROR, "Could not encode RACH burst "
+						"(ra=%u bsic=%u)\n", req->ra, trx->bsic);
 
 			/* Forget this primitive */
 			sched_prim_drop(lchan);
diff --git a/src/host/trxcon/sched_lchan_tchf.c b/src/host/trxcon/sched_lchan_tchf.c
index cec7daf..f2ecdcc 100644
--- a/src/host/trxcon/sched_lchan_tchf.c
+++ b/src/host/trxcon/sched_lchan_tchf.c
@@ -239,7 +239,9 @@
 	/* Encode payload */
 	rc = gsm0503_tch_fr_encode(buffer, lchan->prim->payload, l2_len, 1);
 	if (rc) {
-		LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n");
+		LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n",
+		     lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload,
+							    lchan->prim->payload_len));
 
 		/* Forget this primitive */
 		sched_prim_drop(lchan);
diff --git a/src/host/trxcon/sched_lchan_tchh.c b/src/host/trxcon/sched_lchan_tchh.c
index 172f54b..0201ee3 100644
--- a/src/host/trxcon/sched_lchan_tchh.c
+++ b/src/host/trxcon/sched_lchan_tchh.c
@@ -445,7 +445,9 @@
 	/* Encode the payload */
 	rc = gsm0503_tch_hr_encode(buffer, lchan->prim->payload, l2_len);
 	if (rc) {
-		LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n");
+		LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n",
+		     lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload,
+							    lchan->prim->payload_len));
 
 		/* Forget this primitive */
 		sched_prim_drop(lchan);
diff --git a/src/host/trxcon/sched_lchan_xcch.c b/src/host/trxcon/sched_lchan_xcch.c
index 2d2b1d9..196f949 100644
--- a/src/host/trxcon/sched_lchan_xcch.c
+++ b/src/host/trxcon/sched_lchan_xcch.c
@@ -155,7 +155,9 @@
 	/* Encode payload */
 	rc = gsm0503_xcch_encode(buffer, lchan->prim->payload);
 	if (rc) {
-		LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n");
+		LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n",
+		     lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload,
+							    lchan->prim->payload_len));
 
 		/* Forget this primitive */
 		sched_prim_drop(lchan);

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14637
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I35a7c5df4fc0ed2195ba721f92812874011459d9
Gerrit-Change-Number: 14637
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190701/1192156e/attachment.html>


More information about the gerrit-log mailing list