<p>fixeria <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14637">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon/scheduler: enrich GSM 05.03 encoding error messages<br><br>Change-Id: I35a7c5df4fc0ed2195ba721f92812874011459d9<br>---<br>M src/host/trxcon/sched_lchan_pdtch.c<br>M src/host/trxcon/sched_lchan_rach.c<br>M src/host/trxcon/sched_lchan_tchf.c<br>M src/host/trxcon/sched_lchan_tchh.c<br>M src/host/trxcon/sched_lchan_xcch.c<br>5 files changed, 16 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/sched_lchan_pdtch.c b/src/host/trxcon/sched_lchan_pdtch.c</span><br><span>index 845ef64..ad021a9 100644</span><br><span>--- a/src/host/trxcon/sched_lchan_pdtch.c</span><br><span>+++ b/src/host/trxcon/sched_lchan_pdtch.c</span><br><span>@@ -146,7 +146,9 @@</span><br><span>    rc = gsm0503_pdtch_encode(buffer, lchan->prim->payload,</span><br><span>                lchan->prim->payload_len);</span><br><span>     if (rc) {</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n");</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                     lchan->prim->payload_len));</span><br><span> </span><br><span>            /* Forget this primitive */</span><br><span>          sched_prim_drop(lchan);</span><br><span>diff --git a/src/host/trxcon/sched_lchan_rach.c b/src/host/trxcon/sched_lchan_rach.c</span><br><span>index e96a0e6..5d1f3ab 100644</span><br><span>--- a/src/host/trxcon/sched_lchan_rach.c</span><br><span>+++ b/src/host/trxcon/sched_lchan_rach.c</span><br><span>@@ -108,7 +108,8 @@</span><br><span>           /* Encode extended (11-bit) payload */</span><br><span>               rc = gsm0503_rach_ext_encode(payload, ext_req->ra11, trx->bsic, true);</span><br><span>                 if (rc) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       LOGP(DSCHD, LOGL_ERROR, "Could not encode extended RACH burst\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                  LOGP(DSCHD, LOGL_ERROR, "Could not encode extended RACH burst "</span><br><span style="color: hsl(120, 100%, 40%);">+                                             "(ra=%u bsic=%u)\n", ext_req->ra11, trx->bsic);</span><br><span> </span><br><span>                  /* Forget this primitive */</span><br><span>                  sched_prim_drop(lchan);</span><br><span>@@ -125,7 +126,8 @@</span><br><span>                /* Encode regular (8-bit) payload */</span><br><span>                 rc = gsm0503_rach_ext_encode(payload, req->ra, trx->bsic, false);</span><br><span>              if (rc) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       LOGP(DSCHD, LOGL_ERROR, "Could not encode RACH burst\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                   LOGP(DSCHD, LOGL_ERROR, "Could not encode RACH burst "</span><br><span style="color: hsl(120, 100%, 40%);">+                                              "(ra=%u bsic=%u)\n", req->ra, trx->bsic);</span><br><span> </span><br><span>                        /* Forget this primitive */</span><br><span>                  sched_prim_drop(lchan);</span><br><span>diff --git a/src/host/trxcon/sched_lchan_tchf.c b/src/host/trxcon/sched_lchan_tchf.c</span><br><span>index cec7daf..f2ecdcc 100644</span><br><span>--- a/src/host/trxcon/sched_lchan_tchf.c</span><br><span>+++ b/src/host/trxcon/sched_lchan_tchf.c</span><br><span>@@ -239,7 +239,9 @@</span><br><span>   /* Encode payload */</span><br><span>         rc = gsm0503_tch_fr_encode(buffer, lchan->prim->payload, l2_len, 1);</span><br><span>   if (rc) {</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n");</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                     lchan->prim->payload_len));</span><br><span> </span><br><span>            /* Forget this primitive */</span><br><span>          sched_prim_drop(lchan);</span><br><span>diff --git a/src/host/trxcon/sched_lchan_tchh.c b/src/host/trxcon/sched_lchan_tchh.c</span><br><span>index 172f54b..0201ee3 100644</span><br><span>--- a/src/host/trxcon/sched_lchan_tchh.c</span><br><span>+++ b/src/host/trxcon/sched_lchan_tchh.c</span><br><span>@@ -445,7 +445,9 @@</span><br><span>   /* Encode the payload */</span><br><span>     rc = gsm0503_tch_hr_encode(buffer, lchan->prim->payload, l2_len);</span><br><span>      if (rc) {</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n");</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                     lchan->prim->payload_len));</span><br><span> </span><br><span>            /* Forget this primitive */</span><br><span>          sched_prim_drop(lchan);</span><br><span>diff --git a/src/host/trxcon/sched_lchan_xcch.c b/src/host/trxcon/sched_lchan_xcch.c</span><br><span>index 2d2b1d9..196f949 100644</span><br><span>--- a/src/host/trxcon/sched_lchan_xcch.c</span><br><span>+++ b/src/host/trxcon/sched_lchan_xcch.c</span><br><span>@@ -155,7 +155,9 @@</span><br><span>   /* Encode payload */</span><br><span>         rc = gsm0503_xcch_encode(buffer, lchan->prim->payload);</span><br><span>        if (rc) {</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n");</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload,</span><br><span style="color: hsl(120, 100%, 40%);">+                                                     lchan->prim->payload_len));</span><br><span> </span><br><span>            /* Forget this primitive */</span><br><span>          sched_prim_drop(lchan);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14637">change 14637</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/14637"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I35a7c5df4fc0ed2195ba721f92812874011459d9 </div>
<div style="display:none"> Gerrit-Change-Number: 14637 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>