Change in osmo-msc[master]: mm_rx_id_resp(): use osmo_mi_name()

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12522


Change subject: mm_rx_id_resp(): use osmo_mi_name()
......................................................................

mm_rx_id_resp(): use osmo_mi_name()

Change-Id: I6bb053def223ed698351ad9f52c1e36293df5d59
---
M src/libmsc/gsm_04_08.c
1 file changed, 4 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/22/12522/1

diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 8b225b2..7f6da3e 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -290,8 +290,8 @@
 static int mm_rx_id_resp(struct ran_conn *conn, struct msgb *msg)
 {
 	struct gsm48_hdr *gh = msgb_l3(msg);
-	uint8_t mi_type = gh->data[1] & GSM_MI_TYPE_MASK;
-	char mi_string[GSM48_MI_SIZE];
+	uint8_t *mi = gh->data+1;
+	uint8_t mi_len = gh->data[0];
 
 	if (!conn->vsub) {
 		LOGP(DMM, LOGL_ERROR,
@@ -299,13 +299,11 @@
 		return -EINVAL;
 	}
 
-	gsm48_mi_to_string(mi_string, sizeof(mi_string), &gh->data[1], gh->data[0]);
-	DEBUGP(DMM, "IDENTITY RESPONSE: MI(%s)=%s\n",
-		gsm48_mi_type_name(mi_type), mi_string);
+	DEBUGP(DMM, "IDENTITY RESPONSE: MI=%s\n", osmo_mi_name(mi, mi_len));
 
 	osmo_signal_dispatch(SS_SUBSCR, S_SUBSCR_IDENTITY, gh->data);
 
-	return vlr_subscr_rx_id_resp(conn->vsub, gh->data+1, gh->data[0]);
+	return vlr_subscr_rx_id_resp(conn->vsub, mi, mi_len);
 }
 
 /* Chapter 9.2.15: Receive Location Updating Request.

-- 
To view, visit https://gerrit.osmocom.org/12522
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6bb053def223ed698351ad9f52c1e36293df5d59
Gerrit-Change-Number: 12522
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190110/23f20d91/attachment.htm>