<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12522">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mm_rx_id_resp(): use osmo_mi_name()<br><br>Change-Id: I6bb053def223ed698351ad9f52c1e36293df5d59<br>---<br>M src/libmsc/gsm_04_08.c<br>1 file changed, 4 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/22/12522/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c</span><br><span>index 8b225b2..7f6da3e 100644</span><br><span>--- a/src/libmsc/gsm_04_08.c</span><br><span>+++ b/src/libmsc/gsm_04_08.c</span><br><span>@@ -290,8 +290,8 @@</span><br><span> static int mm_rx_id_resp(struct ran_conn *conn, struct msgb *msg)</span><br><span> {</span><br><span>         struct gsm48_hdr *gh = msgb_l3(msg);</span><br><span style="color: hsl(0, 100%, 40%);">-    uint8_t mi_type = gh->data[1] & GSM_MI_TYPE_MASK;</span><br><span style="color: hsl(0, 100%, 40%);">-        char mi_string[GSM48_MI_SIZE];</span><br><span style="color: hsl(120, 100%, 40%);">+        uint8_t *mi = gh->data+1;</span><br><span style="color: hsl(120, 100%, 40%);">+  uint8_t mi_len = gh->data[0];</span><br><span> </span><br><span>         if (!conn->vsub) {</span><br><span>                LOGP(DMM, LOGL_ERROR,</span><br><span>@@ -299,13 +299,11 @@</span><br><span>                return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   gsm48_mi_to_string(mi_string, sizeof(mi_string), &gh->data[1], gh->data[0]);</span><br><span style="color: hsl(0, 100%, 40%);">-  DEBUGP(DMM, "IDENTITY RESPONSE: MI(%s)=%s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-         gsm48_mi_type_name(mi_type), mi_string);</span><br><span style="color: hsl(120, 100%, 40%);">+      DEBUGP(DMM, "IDENTITY RESPONSE: MI=%s\n", osmo_mi_name(mi, mi_len));</span><br><span> </span><br><span>   osmo_signal_dispatch(SS_SUBSCR, S_SUBSCR_IDENTITY, gh->data);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    return vlr_subscr_rx_id_resp(conn->vsub, gh->data+1, gh->data[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+   return vlr_subscr_rx_id_resp(conn->vsub, mi, mi_len);</span><br><span> }</span><br><span> </span><br><span> /* Chapter 9.2.15: Receive Location Updating Request.</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12522">change 12522</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12522"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6bb053def223ed698351ad9f52c1e36293df5d59 </div>
<div style="display:none"> Gerrit-Change-Number: 12522 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>