This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12382 ) Change subject: tests/gsup_test.c: drop session IEs from MO-ForwardSM Error ...................................................................... tests/gsup_test.c: drop session IEs from MO-ForwardSM Error Both session state and session ID IEs were left from the initial version of Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71. There is no need to use them (as we use SM-RP-MR), so let's clean up. Change-Id: I0d910b87f15ffbc0aeeca9cb4fcbef32bdf3ef88 --- M tests/gsup/gsup_test.c M tests/gsup/gsup_test.err 2 files changed, 4 insertions(+), 10 deletions(-) Approvals: Neels Hofmeyr: Looks good to me, approved Max: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/gsup/gsup_test.c b/tests/gsup/gsup_test.c index f194573..4ad7431 100644 --- a/tests/gsup/gsup_test.c +++ b/tests/gsup/gsup_test.c @@ -256,12 +256,6 @@ 0x25, /* OSMO_GSUP_MSGT_MO_FORWARD_SM_ERROR */ TEST_IMSI_IE, - /* Session related IEs */ - 0x30, 0x04, /* Session ID */ - 0xde, 0xad, 0xbe, 0xef, - 0x31, 0x01, /* Session state (END) */ - 0x03, - /* SM related IEs */ 0x40, 0x01, /* SM-RP-MR (Message Reference) */ 0xfa, diff --git a/tests/gsup/gsup_test.err b/tests/gsup/gsup_test.err index 73b35fc..225735e 100644 --- a/tests/gsup/gsup_test.err +++ b/tests/gsup/gsup_test.err @@ -58,8 +58,8 @@ generated message: 2a 01 08 21 43 65 87 09 21 43 f5 40 01 fa 43 04 de ad be ef original message: 2a 01 08 21 43 65 87 09 21 43 f5 40 01 fa 43 04 de ad be ef IMSI: 123456789012345 - generated message: 25 01 08 21 43 65 87 09 21 43 f5 30 04 de ad be ef 31 01 03 40 01 fa 44 01 af - original message: 25 01 08 21 43 65 87 09 21 43 f5 30 04 de ad be ef 31 01 03 40 01 fa 44 01 af + generated message: 25 01 08 21 43 65 87 09 21 43 f5 40 01 fa 44 01 af + original message: 25 01 08 21 43 65 87 09 21 43 f5 40 01 fa 44 01 af IMSI: 123456789012345 generated message: 2c 01 08 21 43 65 87 09 21 43 f5 46 01 02 original message: 2c 01 08 21 43 65 87 09 21 43 f5 46 01 02 @@ -93,7 +93,7 @@ message 17: tested 33 truncations, 29 parse failures message 18: tested 44 truncations, 39 parse failures message 19: tested 20 truncations, 18 parse failures - message 20: tested 26 truncations, 22 parse failures + message 20: tested 17 truncations, 15 parse failures message 21: tested 14 truncations, 13 parse failures message 22: tested 22 truncations, 21 parse failures message 23: tested 14 truncations, 13 parse failures @@ -119,7 +119,7 @@ message 17: tested 8448 modifications, 2053 parse failures message 18: tested 11264 modifications, 2307 parse failures message 19: tested 5120 modifications, 1031 parse failures - message 20: tested 6656 modifications, 1546 parse failures + message 20: tested 4352 modifications, 1030 parse failures message 21: tested 3584 modifications, 771 parse failures message 22: tested 5632 modifications, 771 parse failures message 23: tested 3584 modifications, 770 parse failures -- To view, visit https://gerrit.osmocom.org/12382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0d910b87f15ffbc0aeeca9cb4fcbef32bdf3ef88 Gerrit-Change-Number: 12382 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190105/dfb75701/attachment.htm>