<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12382">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Neels Hofmeyr: Looks good to me, approved
Max: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/gsup_test.c: drop session IEs from MO-ForwardSM Error<br><br>Both session state and session ID IEs were left from the initial<br>version of Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71. There is<br>no need to use them (as we use SM-RP-MR), so let's clean up.<br><br>Change-Id: I0d910b87f15ffbc0aeeca9cb4fcbef32bdf3ef88<br>---<br>M tests/gsup/gsup_test.c<br>M tests/gsup/gsup_test.err<br>2 files changed, 4 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/gsup/gsup_test.c b/tests/gsup/gsup_test.c</span><br><span>index f194573..4ad7431 100644</span><br><span>--- a/tests/gsup/gsup_test.c</span><br><span>+++ b/tests/gsup/gsup_test.c</span><br><span>@@ -256,12 +256,6 @@</span><br><span> 0x25, /* OSMO_GSUP_MSGT_MO_FORWARD_SM_ERROR */</span><br><span> TEST_IMSI_IE,</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Session related IEs */</span><br><span style="color: hsl(0, 100%, 40%);">- 0x30, 0x04, /* Session ID */</span><br><span style="color: hsl(0, 100%, 40%);">- 0xde, 0xad, 0xbe, 0xef,</span><br><span style="color: hsl(0, 100%, 40%);">- 0x31, 0x01, /* Session state (END) */</span><br><span style="color: hsl(0, 100%, 40%);">- 0x03,</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* SM related IEs */</span><br><span> 0x40, 0x01, /* SM-RP-MR (Message Reference) */</span><br><span> 0xfa,</span><br><span>diff --git a/tests/gsup/gsup_test.err b/tests/gsup/gsup_test.err</span><br><span>index 73b35fc..225735e 100644</span><br><span>--- a/tests/gsup/gsup_test.err</span><br><span>+++ b/tests/gsup/gsup_test.err</span><br><span>@@ -58,8 +58,8 @@</span><br><span> generated message: 2a 01 08 21 43 65 87 09 21 43 f5 40 01 fa 43 04 de ad be ef </span><br><span> original message: 2a 01 08 21 43 65 87 09 21 43 f5 40 01 fa 43 04 de ad be ef </span><br><span> IMSI: 123456789012345</span><br><span style="color: hsl(0, 100%, 40%);">- generated message: 25 01 08 21 43 65 87 09 21 43 f5 30 04 de ad be ef 31 01 03 40 01 fa 44 01 af </span><br><span style="color: hsl(0, 100%, 40%);">- original message: 25 01 08 21 43 65 87 09 21 43 f5 30 04 de ad be ef 31 01 03 40 01 fa 44 01 af </span><br><span style="color: hsl(120, 100%, 40%);">+ generated message: 25 01 08 21 43 65 87 09 21 43 f5 40 01 fa 44 01 af </span><br><span style="color: hsl(120, 100%, 40%);">+ original message: 25 01 08 21 43 65 87 09 21 43 f5 40 01 fa 44 01 af </span><br><span> IMSI: 123456789012345</span><br><span> generated message: 2c 01 08 21 43 65 87 09 21 43 f5 46 01 02 </span><br><span> original message: 2c 01 08 21 43 65 87 09 21 43 f5 46 01 02 </span><br><span>@@ -93,7 +93,7 @@</span><br><span> message 17: tested 33 truncations, 29 parse failures</span><br><span> message 18: tested 44 truncations, 39 parse failures</span><br><span> message 19: tested 20 truncations, 18 parse failures</span><br><span style="color: hsl(0, 100%, 40%);">- message 20: tested 26 truncations, 22 parse failures</span><br><span style="color: hsl(120, 100%, 40%);">+ message 20: tested 17 truncations, 15 parse failures</span><br><span> message 21: tested 14 truncations, 13 parse failures</span><br><span> message 22: tested 22 truncations, 21 parse failures</span><br><span> message 23: tested 14 truncations, 13 parse failures</span><br><span>@@ -119,7 +119,7 @@</span><br><span> message 17: tested 8448 modifications, 2053 parse failures</span><br><span> message 18: tested 11264 modifications, 2307 parse failures</span><br><span> message 19: tested 5120 modifications, 1031 parse failures</span><br><span style="color: hsl(0, 100%, 40%);">- message 20: tested 6656 modifications, 1546 parse failures</span><br><span style="color: hsl(120, 100%, 40%);">+ message 20: tested 4352 modifications, 1030 parse failures</span><br><span> message 21: tested 3584 modifications, 771 parse failures</span><br><span> message 22: tested 5632 modifications, 771 parse failures</span><br><span> message 23: tested 3584 modifications, 770 parse failures</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12382">change 12382</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12382"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0d910b87f15ffbc0aeeca9cb4fcbef32bdf3ef88 </div>
<div style="display:none"> Gerrit-Change-Number: 12382 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>