This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12945 ) Change subject: PCUIF: Use OCT4 for IP address, not uint32_t ...................................................................... PCUIF: Use OCT4 for IP address, not uint32_t In TTCN-3, a 4-byte octetstring is the more usual representation for IP addresses, not an integer type. This is also what functions like f_inet_addr() etc. are using as types, and we may want to use them in combination with the PCUIF. Change-Id: Ia08e1bb8a9bfbd5bf5b63922c77bb221ce1a12f5 --- M library/PCUIF_Types.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified Pau Espin Pedrol: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn index 89a4c33..3215c4b 100644 --- a/library/PCUIF_Types.ttcn +++ b/library/PCUIF_Types.ttcn @@ -164,7 +164,7 @@ record length(2) of uint16_t nsvci, record length(2) of uint16_t local_pprt, record length(2) of uint16_t remote_port, - record length(2) of uint32_t remote_ip + record length(2) of OCT4 remote_ip } with { variant "" } type record PCUIF_act_req { @@ -646,7 +646,7 @@ template (value) uint16_t bvci, template (value) uint16_t local_port, template (value) uint16_t remote_port, - template (value) uint32_t remote_ip, + template (value) OCT4 remote_ip, template (value) PCUIF_Flags flags := c_PCUIF_Flags_default, template (value) uint16_t mcc := 262, template (value) uint16_t mnc := 42, @@ -693,7 +693,7 @@ nsvci := { nsvci, 0 }, local_pprt := { local_port, 0 }, remote_port := { remote_port, 0 }, - remote_ip := { remote_ip , 0 } + remote_ip := { remote_ip , '00000000'O } } } } -- To view, visit https://gerrit.osmocom.org/12945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia08e1bb8a9bfbd5bf5b63922c77bb221ce1a12f5 Gerrit-Change-Number: 12945 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190219/c92bf589/attachment.htm>