<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12945">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">PCUIF: Use OCT4 for IP address, not uint32_t<br><br>In TTCN-3, a 4-byte octetstring is the more usual representation for<br>IP addresses, not an integer type.  This is also what functions like<br>f_inet_addr() etc. are using as types, and we may want to use them<br>in combination with the PCUIF.<br><br>Change-Id: Ia08e1bb8a9bfbd5bf5b63922c77bb221ce1a12f5<br>---<br>M library/PCUIF_Types.ttcn<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn</span><br><span>index 89a4c33..3215c4b 100644</span><br><span>--- a/library/PCUIF_Types.ttcn</span><br><span>+++ b/library/PCUIF_Types.ttcn</span><br><span>@@ -164,7 +164,7 @@</span><br><span>         record length(2) of uint16_t    nsvci,</span><br><span>       record length(2) of uint16_t    local_pprt,</span><br><span>  record length(2) of uint16_t    remote_port,</span><br><span style="color: hsl(0, 100%, 40%);">-    record length(2) of uint32_t    remote_ip</span><br><span style="color: hsl(120, 100%, 40%);">+     record length(2) of OCT4        remote_ip</span><br><span> } with { variant "" }</span><br><span> </span><br><span> type record PCUIF_act_req {</span><br><span>@@ -646,7 +646,7 @@</span><br><span>                                                 template (value) uint16_t bvci,</span><br><span>                                              template (value) uint16_t local_port,</span><br><span>                                                template (value) uint16_t remote_port,</span><br><span style="color: hsl(0, 100%, 40%);">-                                          template (value) uint32_t remote_ip,</span><br><span style="color: hsl(120, 100%, 40%);">+                                          template (value) OCT4 remote_ip,</span><br><span>                                             template (value) PCUIF_Flags flags := c_PCUIF_Flags_default,</span><br><span>                                                 template (value) uint16_t mcc := 262,</span><br><span>                                                template (value) uint16_t mnc := 42,</span><br><span>@@ -693,7 +693,7 @@</span><br><span>                  nsvci := { nsvci, 0 },</span><br><span>                       local_pprt := { local_port, 0 },</span><br><span>                     remote_port := { remote_port, 0 },</span><br><span style="color: hsl(0, 100%, 40%);">-                      remote_ip := { remote_ip , 0 }</span><br><span style="color: hsl(120, 100%, 40%);">+                        remote_ip := { remote_ip , '00000000'O }</span><br><span>             }</span><br><span>    }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12945">change 12945</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12945"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ia08e1bb8a9bfbd5bf5b63922c77bb221ce1a12f5 </div>
<div style="display:none"> Gerrit-Change-Number: 12945 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>