Change in ...libosmocore[master]: sanity: make vty buffer_* API NULL safe

pespin gerrit-no-reply at lists.osmocom.org
Fri Aug 30 10:17:12 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15265 )

Change subject: sanity: make vty buffer_* API NULL safe
......................................................................


Patch Set 3: Code-Review-2

-2 due to previous comments from laforge and me.

Either use OSMO_ASSERT() or drop the patch completely.

imho it doesn't make any sense in general to go early returning on public APIs when the object for which the method is called is NULL (it makes sense for convinience in some specific APIs such as free()).


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15265
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idca3f54dc986abf6784790c12e69e02bdf77cb41
Gerrit-Change-Number: 15265
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Aug 2019 10:17:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190830/d3f27456/attachment.html>


More information about the gerrit-log mailing list