Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

neels gerrit-no-reply at lists.osmocom.org
Thu Aug 29 23:16:15 UTC 2019


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342


Change subject: ran_dec logging: log message sizes on errors
......................................................................

ran_dec logging: log message sizes on errors

Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb
---
M src/libmsc/ran_msg_a.c
1 file changed, 7 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/42/15342/1

diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c
index 5b624a3..c75b656 100644
--- a/src/libmsc/ran_msg_a.c
+++ b/src/libmsc/ran_msg_a.c
@@ -753,13 +753,17 @@
 	}
 
 	if (msgb_l3len(bssmap) < h->length) {
-		LOG_RAN_A_DEC(ran_dec, LOGL_ERROR, "BSSMAP data truncated, discarding message\n");
+		LOG_RAN_A_DEC(ran_dec, LOGL_ERROR, "BSSMAP data truncated, discarding message:"
+			      " msgb_l3len(bssmap) == %u < bssmap_header->length == %u\n",
+			      msgb_l3len(bssmap), h->length);
 		return -1;
 	}
 
 	if (msgb_l3len(bssmap) > h->length) {
-		LOG_RAN_A_DEC(ran_dec, LOGL_NOTICE, "There are %u extra bytes after the BSSMAP data, truncating\n",
-			     msgb_l3len(bssmap) - h->length);
+		LOG_RAN_A_DEC(ran_dec, LOGL_NOTICE, "There are %u extra bytes after the BSSMAP data, truncating:\n",
+			      " msgb_l3len(bssmap) == %u > bssmap_header->length == %u\n",
+			      msgb_l3len(bssmap) - h->length,
+			      msgb_l3len(bssmap), h->length);
 		msgb_l3trim(bssmap, h->length);
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15342
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb
Gerrit-Change-Number: 15342
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/2e598db0/attachment.html>


More information about the gerrit-log mailing list