<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/15342">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ran_dec logging: log message sizes on errors<br><br>Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb<br>---<br>M src/libmsc/ran_msg_a.c<br>1 file changed, 7 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/42/15342/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c</span><br><span>index 5b624a3..c75b656 100644</span><br><span>--- a/src/libmsc/ran_msg_a.c</span><br><span>+++ b/src/libmsc/ran_msg_a.c</span><br><span>@@ -753,13 +753,17 @@</span><br><span>   }</span><br><span> </span><br><span>        if (msgb_l3len(bssmap) < h->length) {</span><br><span style="color: hsl(0, 100%, 40%);">-             LOG_RAN_A_DEC(ran_dec, LOGL_ERROR, "BSSMAP data truncated, discarding message\n");</span><br><span style="color: hsl(120, 100%, 40%);">+          LOG_RAN_A_DEC(ran_dec, LOGL_ERROR, "BSSMAP data truncated, discarding message:"</span><br><span style="color: hsl(120, 100%, 40%);">+                           " msgb_l3len(bssmap) == %u < bssmap_header->length == %u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                          msgb_l3len(bssmap), h->length);</span><br><span>             return -1;</span><br><span>   }</span><br><span> </span><br><span>        if (msgb_l3len(bssmap) > h->length) {</span><br><span style="color: hsl(0, 100%, 40%);">-             LOG_RAN_A_DEC(ran_dec, LOGL_NOTICE, "There are %u extra bytes after the BSSMAP data, truncating\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                        msgb_l3len(bssmap) - h->length);</span><br><span style="color: hsl(120, 100%, 40%);">+              LOG_RAN_A_DEC(ran_dec, LOGL_NOTICE, "There are %u extra bytes after the BSSMAP data, truncating:\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                              " msgb_l3len(bssmap) == %u > bssmap_header->length == %u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                          msgb_l3len(bssmap) - h->length,</span><br><span style="color: hsl(120, 100%, 40%);">+                            msgb_l3len(bssmap), h->length);</span><br><span>             msgb_l3trim(bssmap, h->length);</span><br><span>   }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/15342">change 15342</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/15342"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb </div>
<div style="display:none"> Gerrit-Change-Number: 15342 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>