Change in ...osmo-bts[master]: pcu_sock: fix endian-swapped CellID

osmith gerrit-no-reply at
Thu Aug 29 13:46:24 UTC 2019

osmith has posted comments on this change. ( )

Change subject: pcu_sock: fix endian-swapped CellID

Patch Set 2:

(1 comment) 
Commit Message: 
PS1, Line 14: to OsmoBTS, then with a socket to OsmoPCU. OsmoBTS was always sending
> "the CellID is configured in OsmoBSC, sent via RSL to OsmoBTS" -> as BE.


> "OsmoBTS was always sending the swapped CellID to OsmoPCU" -> meaning it's sending a BE integer over a unix socket in a LE system(wrong!)? Or swapping the value before sending it over the unix socket (correct)?

Meaning it was sending a BE integer over a unix socket in a LE system, which is wrong.

> "In March 2018, a regression in OsmoPCU ([1]) caused it to swap the CellID again" -> What do you mean with "spaw" here? moved in code? because I see it moves the line but still uses ntohs().

I don't mean moved in the code. After the patch, it passes ntohs(info_ind->cell_id) instead of info_ind->cell_id to gprs_bssgp_create_and_connect():

> Please rework the commit description so it's clear what you mean.


To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I68faf4558f0686fb2a3db24077dceaae05bf0262
Gerrit-Change-Number: 15326
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at>
Gerrit-Reviewer: neels <nhofmeyr at>
Gerrit-Reviewer: osmith <osmith at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-Comment-Date: Thu, 29 Aug 2019 13:46:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list