This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15326 ) Change subject: pcu_sock: fix endian-swapped CellID ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15326/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15326/1//COMMIT_MSG@14 PS1, Line 14: to OsmoBTS, then with a socket to OsmoPCU. OsmoBTS was always sending > "the CellID is configured in OsmoBSC, sent via RSL to OsmoBTS" -> as BE. Yes. > "OsmoBTS was always sending the swapped CellID to OsmoPCU" -> meaning it's sending a BE integer over a unix socket in a LE system(wrong!)? Or swapping the value before sending it over the unix socket (correct)? Meaning it was sending a BE integer over a unix socket in a LE system, which is wrong. > "In March 2018, a regression in OsmoPCU ([1]) caused it to swap the CellID again" -> What do you mean with "spaw" here? moved in code? because I see it moves the line but still uses ntohs(). I don't mean moved in the code. After the patch, it passes ntohs(info_ind->cell_id) instead of info_ind->cell_id to gprs_bssgp_create_and_connect(): https://gerrit.osmocom.org/c/osmo-pcu/+/6666/3/src/pcu_l1_if.cpp#493 > Please rework the commit description so it's clear what you mean. Done. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I68faf4558f0686fb2a3db24077dceaae05bf0262 Gerrit-Change-Number: 15326 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 29 Aug 2019 13:46:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/4ac09e5b/attachment.htm>