Change in ...osmo-bts[master]: pcu_sock: fix endian-swapped CellID

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu Aug 29 13:48:42 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15326 )

Change subject: pcu_sock: fix endian-swapped CellID
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/15326/1/src/common/pcu_sock.c 
File src/common/pcu_sock.c:

https://gerrit.osmocom.org/#/c/15326/1/src/common/pcu_sock.c@262 
PS1, Line 262: 		bts->cell_identity = ntohs(si3->cell_identity);
> So here we are again handling a BE integer coming from a unix socket (intra-host)? Why? I'd expect t […]
The data in "si3" was received via RSL, we are converting it to LE on a LE system, to pass that LE version to the unix socket.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15326
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I68faf4558f0686fb2a3db24077dceaae05bf0262
Gerrit-Change-Number: 15326
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Aug 2019 13:48:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/2704c393/attachment.htm>


More information about the gerrit-log mailing list