Change in ...osmo-sgsn[master]: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 20 15:30:05 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 )

Change subject: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12009/2/src/gprs/gprs_gmm.c 
File src/gprs/gprs_gmm.c:

https://gerrit.osmocom.org/#/c/12009/2/src/gprs/gprs_gmm.c@169 
PS2, Line 169: 			  T, mm->gb.state_T);
> Is it intentional, that the timer gets re-scheduled below even if the error message was written? If  […]
I'd say that's pretty standard warning regarding timers of this kind. It's simply a way of logging showing some state transition probably not expected (but if it happens it should be clarified).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/12009
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4ce23ebe50d141076c20c9c56990b7103cd25e55
Gerrit-Change-Number: 12009
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Assignee: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2019 15:30:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190820/7c6f9c2b/attachment.html>


More information about the gerrit-log mailing list