This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 ) Change subject: gprs/gprs_gmm: implement T3314. Timeout to reset MM state READY->STANDBY ...................................................................... Patch Set 2: Code-Review-1 (4 comments) -1 because of missing breaks https://gerrit.osmocom.org/#/c/12009/2/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/12009/2/src/gprs/gprs_gmm.c@150 PS2, Line 150: mmctx_set_mm_state(mm, MM_STANDBY); missing "break" https://gerrit.osmocom.org/#/c/12009/2/src/gprs/gprs_gmm.c@153 PS2, Line 153: get_value_string(gprs_pmm_state_names, mm->pmm_state)); missing "break" https://gerrit.osmocom.org/#/c/12009/2/src/gprs/gprs_gmm.c@169 PS2, Line 169: T, mm->gb.state_T); Is it intentional, that the timer gets re-scheduled below even if the error message was written? If so, maybe it makes sense to mention this in the message, reading it now makes it seem like it does not change the timer, because it is already active. https://gerrit.osmocom.org/#/c/12009/2/src/gprs/gprs_gmm.c@3076 PS2, Line 3076: gsm0408_gprs_notify_pdu_gb(mmctx); why is this not part of the above "if (mmctx)"? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/12009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4ce23ebe50d141076c20c9c56990b7103cd25e55 Gerrit-Change-Number: 12009 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at gnumonks.org> Gerrit-Assignee: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2019 11:07:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190820/97d285cf/attachment.htm>