Change in ...osmo-bsc[master]: gsm_08_08.c: always pick first msc for unsolicit paging responses
gerrit-no-reply at lists.osmocom.org
Thu Aug 15 15:55:11 UTC 2019
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15209 )
Change subject: gsm_08_08.c: always pick first msc for unsolicit paging responses
Patch Set 1:
PS1, Line 328: LOGP(DMSC, LOGL_ERROR, "Got paged but no subscriber found, will now (blindly) deliver the paging response to the first configured MSC!\n");
> s/Got paged/Got Paging Response ?
PS1, Line 349: LOGL_ERROR
this is not an error condition, but a perfectly normal situation in the context of CSFB. It should be INFO, maximum.
PS1, Line 358: * blindly. */
> This entire code looks like weird legacy bsc-nat stuff, I've never used osmo-bsc with more than one […]
the code is unrelated to bsc-nat. OsmoBSC once was extended to talk to multiple MSC so you can have a "remote" normal BSC and a local one in case your backhaul fails, or in case you want to route some subscribers locally onboard a vessel. That use case has disappeared now, we could remove it. But we must not change the VTY syntax while doing it. In any case that's unrelated to the current patch.
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15209
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Aug 2019 15:55:11 +0000
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log