Change in ...osmo-bsc[master]: gsm_08_08.c: always pick first msc for unsolicit paging responses
gerrit-no-reply at lists.osmocom.org
Thu Aug 15 00:28:08 UTC 2019
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15209 )
Change subject: gsm_08_08.c: always pick first msc for unsolicit paging responses
Patch Set 1:
agree to fix the Change-Id duality, otherwise +1 from me
PS1, Line 328: LOGP(DMSC, LOGL_ERROR, "Got paged but no subscriber found, will now (blindly) deliver the paging response to the first configured MSC!\n");
s/Got paged/Got Paging Response ?
PS1, Line 358: * blindly. */
> As commented on other patch, shouldn't this be VTY configurable? (to which MSC send them).
This entire code looks like weird legacy bsc-nat stuff, I've never used osmo-bsc with more than one MSC.
I think it makes a lot of sense to send the CSFB Paging Response to The One MSC.
The entire going through lists of MSCs is a legacy nonsense that we should probably remove anyway.
Correct me if I'm wrong (laforge?) but I think we don't need more vty for multiple MSC scenarios.
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15209
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Aug 2019 00:28:08 +0000
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log