Change in ...osmo-iuh[master]: iu_client: introduce a connection state

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 13 19:32:42 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15181 )

Change subject: iu_client: introduce a connection state
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c 
File src/iu_client.c:

https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c@119 
PS3, Line 119: 	ctx->conn_state = RANAP_CONN_STATE_CONNECTED;
Should be DISCONNECTED.


https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c@143 
PS3, Line 143: 	if (ue->conn_state == RANAP_CONN_STATE_CONNECTED)
You are missing setting state=CONNECTED somehwere.


https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c@823 
PS3, Line 823: 		ue->conn_state = RANAP_CONN_STATE_CONNECTED;
Should be DISCONNECTED.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15181
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I77e01724be05ac488a4685ba367b7a71985b54e3
Gerrit-Change-Number: 15181
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Aug 2019 19:32:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/bdd46b54/attachment.html>


More information about the gerrit-log mailing list