<p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-iuh/+/15181">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c">File src/iu_client.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c@119">Patch Set #3, Line 119:</a> <code style="font-family:monospace,monospace">      ctx->conn_state = RANAP_CONN_STATE_CONNECTED;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be DISCONNECTED.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c@143">Patch Set #3, Line 143:</a> <code style="font-family:monospace,monospace">    if (ue->conn_state == RANAP_CONN_STATE_CONNECTED)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You are missing setting state=CONNECTED somehwere.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c@823">Patch Set #3, Line 823:</a> <code style="font-family:monospace,monospace">             ue->conn_state = RANAP_CONN_STATE_CONNECTED;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should be DISCONNECTED.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-iuh/+/15181">change 15181</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-iuh/+/15181"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-iuh </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I77e01724be05ac488a4685ba367b7a71985b54e3 </div>
<div style="display:none"> Gerrit-Change-Number: 15181 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 13 Aug 2019 19:32:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>