Change in ...osmo-sgsn[master]: gprs_gmm: only update gb/iu cell information when Iu/Gb present

pespin gerrit-no-reply at lists.osmocom.org
Tue Aug 13 15:20:44 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15172 )

Change subject: gprs_gmm: only update gb/iu cell information when Iu/Gb present
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/15172/1/src/gprs/gprs_gmm.c 
File src/gprs/gprs_gmm.c:

https://gerrit.osmocom.org/#/c/15172/1/src/gprs/gprs_gmm.c@306 
PS1, Line 306: #ifdef BUILD_IU
Better move it this way, to avoid a compiler warning on empty else condition:
}
#ifdef BUILD_IU
 else {
...
}
#endif


https://gerrit.osmocom.org/#/c/15172/1/src/gprs/gprs_gmm.c@309 
PS1, Line 309: 		mm->iu.ue_ctx = msg->dst;
Use MSG_IU_UE_CTX_SET()



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15172
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Id52761f3ea655a2d0cc663a950154c6b7c1b5f7a
Gerrit-Change-Number: 15172
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Aug 2019 15:20:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/ace721d4/attachment.html>


More information about the gerrit-log mailing list