Change in ...osmo-sgsn[master]: gprs_gmm: only update gb/iu cell information when Iu/Gb present

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Aug 13 11:41:50 UTC 2019


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15172


Change subject: gprs_gmm: only update gb/iu cell information when Iu/Gb present
......................................................................

gprs_gmm: only update gb/iu cell information when Iu/Gb present

This function should not do the transistion of Iu/Gb. Only copy simple data

Change-Id: Id52761f3ea655a2d0cc663a950154c6b7c1b5f7a
---
M src/gprs/gprs_gmm.c
1 file changed, 13 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/72/15172/1

diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index c8bc0f7..8d8c877 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -298,15 +298,20 @@
 /* Store BVCI/NSEI in MM context */
 static void msgid2mmctx(struct sgsn_mm_ctx *mm, const struct msgb *msg)
 {
-	mm->gb.bvci = msgb_bvci(msg);
-	mm->gb.nsei = msgb_nsei(msg);
-	/* In case a Iu connection is reconnected we need to update the ue ctx */
-	mm->iu.ue_ctx = MSG_IU_UE_CTX(msg);
-	if (mm->ran_type == MM_CTX_T_UTRAN_Iu
-	    && mm->iu.ue_ctx) {
+	/* check for Iu or Gb */
+	if (!MSG_IU_UE_CTX(msg)) {
+		mm->gb.bvci = msgb_bvci(msg);
+		mm->gb.nsei = msgb_nsei(msg);
+	} else {
 #ifdef BUILD_IU
-		mm->iu.ue_ctx->rab_assign_addr_enc =
-			sgsn->cfg.iu.rab_assign_addr_enc;
+		/* In case a Iu connection is reconnected we need to update the ue ctx */
+		/* FIXME: the old ue_ctx have to be freed/disconnected */
+		mm->iu.ue_ctx = msg->dst;
+		if (mm->ran_type == MM_CTX_T_UTRAN_Iu
+				&& mm->iu.ue_ctx) {
+			mm->iu.ue_ctx->rab_assign_addr_enc =
+					sgsn->cfg.iu.rab_assign_addr_enc;
+		}
 #endif
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15172
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Id52761f3ea655a2d0cc663a950154c6b7c1b5f7a
Gerrit-Change-Number: 15172
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190813/0802d63e/attachment.html>


More information about the gerrit-log mailing list