Change in ...osmo-sip-connector[master]: IPs stored in the call struct are NETWORK byte order

keith gerrit-no-reply at lists.osmocom.org
Tue Aug 6 12:07:09 UTC 2019


keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15063


Change subject: IPs stored in the call struct are NETWORK byte order
......................................................................

IPs stored in the call struct are NETWORK byte order

As far as I can make out, the intention is to always store ip address in the call struct
in network byte order, whereas the ip address sent on MNCC are in host byte order.

Change-Id: I89ef26aa32a672f394699251cf560b53ae01a814
---
M src/mncc.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/63/15063/1

diff --git a/src/mncc.c b/src/mncc.c
index 81fe30f..2bd40e9 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -181,7 +181,7 @@
 	 */
 	mncc.msg_type = MNCC_RTP_CONNECT;
 	mncc.callref = leg->callref;
-	mncc.ip = htonl(other->ip);
+	mncc.ip = ntohl(other->ip);
 	mncc.port = other->port;
 	mncc.payload_type = other->payload_type;
 	/*

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15063
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I89ef26aa32a672f394699251cf560b53ae01a814
Gerrit-Change-Number: 15063
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190806/ca0f159c/attachment.html>


More information about the gerrit-log mailing list