<p>keith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15063">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">IPs stored in the call struct are NETWORK byte order<br><br>As far as I can make out, the intention is to always store ip address in the call struct<br>in network byte order, whereas the ip address sent on MNCC are in host byte order.<br><br>Change-Id: I89ef26aa32a672f394699251cf560b53ae01a814<br>---<br>M src/mncc.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/63/15063/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mncc.c b/src/mncc.c</span><br><span>index 81fe30f..2bd40e9 100644</span><br><span>--- a/src/mncc.c</span><br><span>+++ b/src/mncc.c</span><br><span>@@ -181,7 +181,7 @@</span><br><span>        */</span><br><span>  mncc.msg_type = MNCC_RTP_CONNECT;</span><br><span>    mncc.callref = leg->callref;</span><br><span style="color: hsl(0, 100%, 40%);">- mncc.ip = htonl(other->ip);</span><br><span style="color: hsl(120, 100%, 40%);">+        mncc.ip = ntohl(other->ip);</span><br><span>       mncc.port = other->port;</span><br><span>  mncc.payload_type = other->payload_type;</span><br><span>  /*</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15063">change 15063</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15063"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I89ef26aa32a672f394699251cf560b53ae01a814 </div>
<div style="display:none"> Gerrit-Change-Number: 15063 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>