This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15045 ) Change subject: Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds ...................................................................... Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However, definition in C file doesn't contain "(void)", which means number of parameters is undefined and thus compiler doesn't complain. Let's remove parameters from all callers before enforcing "(void)" on it. API osmo_stats_vty_add_cmds never had a param list but has seem problem (no "void"), so some users decided to pass a parameter to it. Change-Id: Icf4d18969488c9eacca7a597d4071828e649e772 Related: OS#4138 --- M src/osmo-mgw/mgw_main.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-mgw/mgw_main.c b/src/osmo-mgw/mgw_main.c index 583d0fb..adc1751 100644 --- a/src/osmo-mgw/mgw_main.c +++ b/src/osmo-mgw/mgw_main.c @@ -270,9 +270,9 @@ vty_info.copyright = osmomgw_copyright; vty_init(&vty_info); - logging_vty_add_cmds(NULL); + logging_vty_add_cmds(); osmo_talloc_vty_add_cmds(); - osmo_stats_vty_add_cmds(&log_info); + osmo_stats_vty_add_cmds(); mgcp_vty_init(); handle_options(argc, argv); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15045 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icf4d18969488c9eacca7a597d4071828e649e772 Gerrit-Change-Number: 15045 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/27513969/attachment.htm>