Change in ...osmo-msc[master]: Remove undefined param passed to logging_vty_add_cmds

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 5 14:07:36 UTC 2019


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15046


Change subject: Remove undefined param passed to logging_vty_add_cmds
......................................................................

Remove undefined param passed to logging_vty_add_cmds

Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.

Change-Id: Ia2b24ffd7f9cbb271fcdb979b851f3a07b9d6d3e
Related: OS#4138
---
M src/osmo-msc/msc_main.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/46/15046/1

diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index 9da26fb..1083271 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -544,7 +544,7 @@
 	}
 
 	ctrl_vty_init(tall_msc_ctx);
-	logging_vty_add_cmds(&log_info);
+	logging_vty_add_cmds();
 	osmo_talloc_vty_add_cmds();
 	msc_vty_init(msc_network);
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b24ffd7f9cbb271fcdb979b851f3a07b9d6d3e
Gerrit-Change-Number: 15046
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/a81d0ae5/attachment.html>


More information about the gerrit-log mailing list