Change in ...osmo-sip-connector[master]: Transmit Bearer Caps to MNCC with SETUP_REQ

fixeria gerrit-no-reply at lists.osmocom.org
Thu Aug 1 22:12:55 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15019 )

Change subject: Transmit Bearer Caps to MNCC with SETUP_REQ
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/15019/1/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/15019/1/src/mncc.c@824 
PS1, Line 824: struct gsm_mncc_bearer_cap bearer_cap
I think you can assign the new structure directly to mncc.bearer_cap, no need for temporary variable. Just a cosmetic comment, I guess compiler would be able to optimize this anyway.


https://gerrit.osmocom.org/#/c/15019/1/src/mncc.c@855 
PS1, Line 855: struct gsm_mncc_bearer_cap bearer_cap 
same here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15019
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I55cdc4b7c52730d7e998a1d692c7552fd07403ee
Gerrit-Change-Number: 15019
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 22:12:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190801/0b23bb01/attachment.html>


More information about the gerrit-log mailing list