<p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15019">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/15019/1/src/mncc.c">File src/mncc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15019/1/src/mncc.c@824">Patch Set #1, Line 824:</a> <code style="font-family:monospace,monospace">struct gsm_mncc_bearer_cap bearer_cap</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think you can assign the new structure directly to mncc.bearer_cap, no need for temporary variable. Just a cosmetic comment, I guess compiler would be able to optimize this anyway.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15019/1/src/mncc.c@855">Patch Set #1, Line 855:</a> <code style="font-family:monospace,monospace">struct gsm_mncc_bearer_cap bearer_cap </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15019">change 15019</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15019"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I55cdc4b7c52730d7e998a1d692c7552fd07403ee </div>
<div style="display:none"> Gerrit-Change-Number: 15019 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 01 Aug 2019 22:12:55 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>