Change in osmo-hlr[master]: add missing error log: invalid IMSI

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Apr 26 19:03:34 UTC 2019


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13587 )

Change subject: add missing error log: invalid IMSI
......................................................................

add missing error log: invalid IMSI

Change-Id: I65e9ecac06dc6d1abb9802d621c385d3b4fab83a
---
M src/hlr.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve



diff --git a/src/hlr.c b/src/hlr.c
index 422a56d..19cfebb 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -454,8 +454,10 @@
 
 	/* 3GPP TS 23.003 Section 2.2 clearly states that an IMSI with less than 5
 	 * digits is impossible.  Even 5 digits is a highly theoretical case */
-	if (strlen(gsup.imsi) < 5)
+	if (strlen(gsup.imsi) < 5) {
+		LOGP(DMAIN, LOGL_ERROR, "IMSI too short: %s\n", osmo_quote_str(gsup.imsi, -1));
 		return gsup_send_err_reply(conn, gsup.imsi, gsup.message_type, GMM_CAUSE_INV_MAND_INFO);
+	}
 
 	switch (gsup.message_type) {
 	/* requests sent to us */

-- 
To view, visit https://gerrit.osmocom.org/13587
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I65e9ecac06dc6d1abb9802d621c385d3b4fab83a
Gerrit-Change-Number: 13587
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190426/adf4b420/attachment.html>


More information about the gerrit-log mailing list