Change in osmo-hlr[master]: add missing error log: invalid IMSI

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Apr 26 19:03:07 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13587 )

Change subject: add missing error log: invalid IMSI
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/13587/1/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/13587/1/src/hlr.c@537
PS1, Line 537: 
> What is the benefit of using osmo_quote_str() here? […]
The point is that the strlen() is invalid. So the IMSI might be empty, or something else might be odd, maybe random memory and invalid characters? osmo_quote_str() guarantees outputting something useful in all cases.



-- 
To view, visit https://gerrit.osmocom.org/13587
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65e9ecac06dc6d1abb9802d621c385d3b4fab83a
Gerrit-Change-Number: 13587
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 26 Apr 2019 19:03:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190426/8df16d21/attachment.html>


More information about the gerrit-log mailing list