Change in osmo-iuh[master]: ranap_msg_factory: Fix criticality of PDUs

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Apr 20 20:40:56 UTC 2019


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13722


Change subject: ranap_msg_factory: Fix criticality of PDUs
......................................................................

ranap_msg_factory: Fix criticality of PDUs

Seveal of our RANAP messages were using criticality values at the
PDU level differing from what RANAP_PDU_Descriptions.asn states
for the respective procedures.  Let's fix that.

This was discovered while working on the initial IuCS TTCN3 tests,
where the receive templates require the criticality to match.

Change-Id: I98eec0bdc0d0cb1b9284bd5d042b1f4403abef95
---
M src/ranap_msg_factory.c
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/22/13722/1

diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c
index c287f02..2ae2dbf 100644
--- a/src/ranap_msg_factory.c
+++ b/src/ranap_msg_factory.c
@@ -150,7 +150,7 @@
 	}
 
 	msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_InitialUE_Message,
-						RANAP_Criticality_reject,
+						RANAP_Criticality_ignore,
 						&asn_DEF_RANAP_InitialUE_Message,
 						&out);
 
@@ -192,7 +192,7 @@
 
 	/* dt -> msg */
 	msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_DirectTransfer,
-						RANAP_Criticality_reject,
+						RANAP_Criticality_ignore,
 						&asn_DEF_RANAP_DirectTransfer,
 						&dt);
 
@@ -467,7 +467,7 @@
 
 	/* out -> msg */
 	msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_Paging,
-						RANAP_Criticality_reject,
+						RANAP_Criticality_ignore,
 						&asn_DEF_RANAP_Paging,
 						&out);
 
@@ -912,7 +912,7 @@
 
 	/* encode the output into the msgb */
 	msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_Iu_ReleaseRequest,
-						RANAP_Criticality_reject,
+						RANAP_Criticality_ignore,
 						&asn_DEF_RANAP_Iu_ReleaseRequest, &out);
 
 	ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_Iu_ReleaseRequest, &out);
@@ -955,7 +955,7 @@
 
 	/* encode the output into the msgb */
 	msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_RAB_ReleaseRequest,
-						RANAP_Criticality_reject,
+						RANAP_Criticality_ignore,
 						&asn_DEF_RANAP_RAB_ReleaseRequest, &out);
 
 	ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_RAB_ReleaseRequest, &out);

-- 
To view, visit https://gerrit.osmocom.org/13722
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98eec0bdc0d0cb1b9284bd5d042b1f4403abef95
Gerrit-Change-Number: 13722
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190420/adc27bde/attachment.html>


More information about the gerrit-log mailing list