<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/13722">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ranap_msg_factory: Fix criticality of PDUs<br><br>Seveal of our RANAP messages were using criticality values at the<br>PDU level differing from what RANAP_PDU_Descriptions.asn states<br>for the respective procedures.  Let's fix that.<br><br>This was discovered while working on the initial IuCS TTCN3 tests,<br>where the receive templates require the criticality to match.<br><br>Change-Id: I98eec0bdc0d0cb1b9284bd5d042b1f4403abef95<br>---<br>M src/ranap_msg_factory.c<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/22/13722/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c</span><br><span>index c287f02..2ae2dbf 100644</span><br><span>--- a/src/ranap_msg_factory.c</span><br><span>+++ b/src/ranap_msg_factory.c</span><br><span>@@ -150,7 +150,7 @@</span><br><span>        }</span><br><span> </span><br><span>        msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_InitialUE_Message,</span><br><span style="color: hsl(0, 100%, 40%);">-                                               RANAP_Criticality_reject,</span><br><span style="color: hsl(120, 100%, 40%);">+                                             RANAP_Criticality_ignore,</span><br><span>                                            &asn_DEF_RANAP_InitialUE_Message,</span><br><span>                                                &out);</span><br><span> </span><br><span>@@ -192,7 +192,7 @@</span><br><span> </span><br><span>     /* dt -> msg */</span><br><span>   msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_DirectTransfer,</span><br><span style="color: hsl(0, 100%, 40%);">-                                          RANAP_Criticality_reject,</span><br><span style="color: hsl(120, 100%, 40%);">+                                             RANAP_Criticality_ignore,</span><br><span>                                            &asn_DEF_RANAP_DirectTransfer,</span><br><span>                                           &dt);</span><br><span> </span><br><span>@@ -467,7 +467,7 @@</span><br><span> </span><br><span>      /* out -> msg */</span><br><span>  msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_Paging,</span><br><span style="color: hsl(0, 100%, 40%);">-                                          RANAP_Criticality_reject,</span><br><span style="color: hsl(120, 100%, 40%);">+                                             RANAP_Criticality_ignore,</span><br><span>                                            &asn_DEF_RANAP_Paging,</span><br><span>                                           &out);</span><br><span> </span><br><span>@@ -912,7 +912,7 @@</span><br><span> </span><br><span>     /* encode the output into the msgb */</span><br><span>        msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_Iu_ReleaseRequest,</span><br><span style="color: hsl(0, 100%, 40%);">-                                               RANAP_Criticality_reject,</span><br><span style="color: hsl(120, 100%, 40%);">+                                             RANAP_Criticality_ignore,</span><br><span>                                            &asn_DEF_RANAP_Iu_ReleaseRequest, &out);</span><br><span> </span><br><span>         ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_Iu_ReleaseRequest, &out);</span><br><span>@@ -955,7 +955,7 @@</span><br><span> </span><br><span>  /* encode the output into the msgb */</span><br><span>        msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_RAB_ReleaseRequest,</span><br><span style="color: hsl(0, 100%, 40%);">-                                              RANAP_Criticality_reject,</span><br><span style="color: hsl(120, 100%, 40%);">+                                             RANAP_Criticality_ignore,</span><br><span>                                            &asn_DEF_RANAP_RAB_ReleaseRequest, &out);</span><br><span> </span><br><span>        ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_RAB_ReleaseRequest, &out);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13722">change 13722</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13722"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-iuh </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I98eec0bdc0d0cb1b9284bd5d042b1f4403abef95 </div>
<div style="display:none"> Gerrit-Change-Number: 13722 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>