Change in osmo-sgsn[master]: gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling G...

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Apr 16 08:07:09 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13654 )

Change subject: gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling GMM Attach Requests
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13654/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13654/1//COMMIT_MSG@11
PS1, Line 11: 
I'm sorry to say that, but this description doesn't explain enough what do you intend to do here, at least for me, and the commit change looks strange too, since basically you add a function call and add a comment with FIXME stating to remove it...

Is the commit related to some redmine issue? Can you extend the description of the commit?



-- 
To view, visit https://gerrit.osmocom.org/13654
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50e8e316f06ae1a6171a6b07e4e2f0761322b779
Gerrit-Change-Number: 13654
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Apr 2019 08:07:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190416/ef28bc2d/attachment.html>


More information about the gerrit-log mailing list