Change in osmo-sgsn[master]: gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling G...

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Apr 16 07:09:03 UTC 2019


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/13654


Change subject: gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling GMM Attach Requests
......................................................................

gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling GMM Attach Requests

A security command complete is part of multiple messages not only the GMM Attach Request and must
go through the gmm authorized as long it's not completely replaced.

Change-Id: I50e8e316f06ae1a6171a6b07e4e2f0761322b779
---
M src/gprs/gprs_gmm.c
1 file changed, 6 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/54/13654/1

diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c
index b0c5902..358bff9 100644
--- a/src/gprs/gprs_gmm.c
+++ b/src/gprs/gprs_gmm.c
@@ -205,7 +205,12 @@
 		REQUIRE_MM
 		/* Continue authentication here */
 		mm->iu.ue_ctx->integrity_active = 1;
-		osmo_fsm_inst_dispatch(mm->gmm_att_req.fsm, E_IU_SECURITY_CMD_COMPLETE, NULL);
+
+		/* FIXME: remove gmm_authorize */
+		if (mm->pending_req != GSM48_MT_GMM_ATTACH_REQ)
+			gsm48_gmm_authorize(mm);
+		else
+			osmo_fsm_inst_dispatch(mm->gmm_att_req.fsm, E_IU_SECURITY_CMD_COMPLETE, NULL);
 		break;
 	default:
 		LOGP(DRANAP, LOGL_NOTICE, "Unknown event received: %i\n", type);

-- 
To view, visit https://gerrit.osmocom.org/13654
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50e8e316f06ae1a6171a6b07e4e2f0761322b779
Gerrit-Change-Number: 13654
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190416/ff031cb4/attachment.html>


More information about the gerrit-log mailing list