Change in osmo-msc[master]: Allow MME name preformatted as FQDN in SGsAP

Omar Ramadan gerrit-no-reply at lists.osmocom.org
Sat Apr 13 21:55:19 UTC 2019


Omar Ramadan has submitted this change and it was merged. ( https://gerrit.osmocom.org/13627 )

Change subject: Allow MME name preformatted as FQDN in SGsAP
......................................................................

Allow MME name preformatted as FQDN in SGsAP

Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9
---
M src/libmsc/sgs_iface.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index eed107a..8b4b61d 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -168,6 +168,12 @@
 	if (!mme_name_enc)
 		return -EINVAL;
 
+	/* some implementations use FDQN format violating TS 29.118 9.3.14 */
+	if (!osmo_parse_mme_domain(&gummei, (const char *) mme_name_enc)) {
+		memcpy(mme_name, mme_name_enc, TLVP_LEN(tp, SGSAP_IE_MME_NAME));
+		return 0;
+	}
+
 	/* decode the MME name from DNS labels to string */
 	osmo_apn_to_str(mme_name, TLVP_VAL(tp, SGSAP_IE_MME_NAME), TLVP_LEN(tp, SGSAP_IE_MME_NAME));
 

-- 
To view, visit https://gerrit.osmocom.org/13627
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9
Gerrit-Change-Number: 13627
Gerrit-PatchSet: 2
Gerrit-Owner: Omar Ramadan <omar.ramadan93 at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Omar Ramadan <omar.ramadan93 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190413/1083bdbd/attachment.html>


More information about the gerrit-log mailing list