<p>Omar Ramadan <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13627">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Allow MME name preformatted as FQDN in SGsAP<br><br>Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9<br>---<br>M src/libmsc/sgs_iface.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c</span><br><span>index eed107a..8b4b61d 100644</span><br><span>--- a/src/libmsc/sgs_iface.c</span><br><span>+++ b/src/libmsc/sgs_iface.c</span><br><span>@@ -168,6 +168,12 @@</span><br><span>    if (!mme_name_enc)</span><br><span>           return -EINVAL;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   /* some implementations use FDQN format violating TS 29.118 9.3.14 */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!osmo_parse_mme_domain(&gummei, (const char *) mme_name_enc)) {</span><br><span style="color: hsl(120, 100%, 40%);">+               memcpy(mme_name, mme_name_enc, TLVP_LEN(tp, SGSAP_IE_MME_NAME));</span><br><span style="color: hsl(120, 100%, 40%);">+              return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* decode the MME name from DNS labels to string */</span><br><span>  osmo_apn_to_str(mme_name, TLVP_VAL(tp, SGSAP_IE_MME_NAME), TLVP_LEN(tp, SGSAP_IE_MME_NAME));</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13627">change 13627</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13627"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9 </div>
<div style="display:none"> Gerrit-Change-Number: 13627 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Omar Ramadan <omar.ramadan93@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Omar Ramadan <omar.ramadan93@gmail.com> </div>