Change in libosmocore[master]: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr
gerrit-no-reply at lists.osmocom.org
Fri Apr 12 00:08:30 UTC 2019
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13259 )
Change subject: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr
Patch Set 9:
PS9, Line 15: the
: gsm0808.c actually also gets built on embedded systems that lack arpa/inet.h
: (for me indicated by the ARM build job on jenkins)
> we can simply not compile 08.08 related functions in the "embedded" case. […]
Yes, I actually did try quite a few things, and in the end decided it's not worth it to waste my time on.
Originally I wanted to use a struct sockaddr as a member in struct gsm0808_handover_*.
In the meantime I have befriended the idea of passing pointers in those structs, so not that urgent.
The core problem was that I cannot use struct sockaddr as a non-opaque struct in the header file.
Even though on embedded, the .c file isn't built, the header file is still included!
And in the .h file one obviously cannot use '#if (!EMBEDDED)', because in /usr/include there is no config.h.
It's not a big deal for me anymore,
but in general the include / compile semantics for gsm0808.h are unsorted/wrong.
To view, visit https://gerrit.osmocom.org/13259
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Apr 2019 00:08:30 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log