Change in libosmocore[master]: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Apr 11 06:08:08 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13259 )

Change subject: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.osmocom.org/#/c/13259/9//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13259/9//COMMIT_MSG@15
PS9, Line 15: the
            : gsm0808.c actually also gets built on embedded systems that lack arpa/inet.h
            : (for me indicated by the ARM build job on jenkins)
we can simply not compile 08.08 related functions in the "embedded" case.  we don't want to implement the A interface on bare iron in a microcontroller firmware. So you can just use a large "#if (!EMBEDDED)" blockaround those parts, or even disable the entire files from Makefile.am in a patch preceding this patch?  Or was this approach attempted and didn't work for some reason? In the latter case I'm happy to investigate why you couldn't deactivate it.



-- 
To view, visit https://gerrit.osmocom.org/13259
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia71542ea37d4fd2c9fb9b40357db7aeb111ec576
Gerrit-Change-Number: 13259
Gerrit-PatchSet: 9
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Apr 2019 06:08:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/ded49c67/attachment.html>


More information about the gerrit-log mailing list