Change in osmo-hlr[master]: USSD: don't use gsm0480_msgb_alloc_name()

osmith gerrit-no-reply at lists.osmocom.org
Thu Apr 11 08:29:18 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13548 )

Change subject: USSD: don't use gsm0480_msgb_alloc_name()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13548/1/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13548/1/src/hlr_ussd.c@244
PS1, Line 244: 	resp_msg = msgb_alloc_headroom(4000, 64, __func__);
> might be good to introduce a #define for it then, and use that #define (maybe a sa preceding patch,  […]
How about OSMO_GSUP_MSGB_HEADROOM_SIZE?

And I would put it into libosmocore, since there seems to be no gsup-related header file in osmo-hlr.git, that is included by both the server and client. Does that make sense?



-- 
To view, visit https://gerrit.osmocom.org/13548
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdab40c6a933888eb9f51bee9c5264c8919dbf7b
Gerrit-Change-Number: 13548
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Apr 2019 08:29:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/51bf98a0/attachment.html>


More information about the gerrit-log mailing list