Change in osmo-hlr[master]: USSD: don't use gsm0480_msgb_alloc_name()

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Apr 11 06:21:25 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13548 )

Change subject: USSD: don't use gsm0480_msgb_alloc_name()
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/13548/1/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13548/1/src/hlr_ussd.c@244
PS1, Line 244: 	resp_msg = msgb_alloc_headroom(4000, 64, __func__);
> To match what osmo_gsup_client_msgb_alloc() is doing, so the server messages have the same size as t […]
might be good to introduce a #define for it then, and use that #define (maybe a sa preceding patch, or as a cleanup patch after this one)



-- 
To view, visit https://gerrit.osmocom.org/13548
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdab40c6a933888eb9f51bee9c5264c8919dbf7b
Gerrit-Change-Number: 13548
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Apr 2019 06:21:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190411/a0b630a3/attachment.html>


More information about the gerrit-log mailing list