Change in osmo-hlr[master]: USSD: save MO USSD's originating MSC's vlr_number

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Apr 9 11:29:28 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13515 )

Change subject: USSD: save MO USSD's originating MSC's vlr_number
......................................................................


Patch Set 11: Code-Review-1

(3 comments)

-1 for missing talloc_strdup(). Didn't notice this before...

https://gerrit.osmocom.org/#/c/13515/11/src/gsup_router.c
File src/gsup_router.c:

https://gerrit.osmocom.org/#/c/13515/11/src/gsup_router.c@54
PS11, Line 54: struct
just noticed (cosmetic, not a merge blocker): const.


https://gerrit.osmocom.org/#/c/13515/11/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13515/11/src/hlr_ussd.c@542
PS11, Line 542: gsup_rt->addr
I think you also need to use talloc_strdup() here, so this would be consistent with ss_gsup_send(). Otherwise somebody would shoot himself / herself in the foot calling talloc_free().


https://gerrit.osmocom.org/#/c/13515/11/src/hlr_ussd.c@546
PS11, Line 546: else
Please use the { ... } brackets here too, so readability++.



-- 
To view, visit https://gerrit.osmocom.org/13515
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a65f471672949192061c5fe396603611123bc1
Gerrit-Change-Number: 13515
Gerrit-PatchSet: 11
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Apr 2019 11:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190409/eb4db8e3/attachment.html>


More information about the gerrit-log mailing list