Change in libosmocore[master]: fsm: support graceful osmo_fsm_inst_term() cascades

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Apr 9 09:20:11 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13392 )

Change subject: fsm: support graceful osmo_fsm_inst_term() cascades
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

it might make sense to expose the value of this global flag variable in the fsm VTY code, so that "show fsm" would give you an indication?

https://gerrit.osmocom.org/#/c/13392/4/src/fsm.c
File src/fsm.c:

https://gerrit.osmocom.org/#/c/13392/4/src/fsm.c@409
PS4, Line 409:  */
> So after all it seems like a bad idea to do this optimization. We
 > don't want to risk our sanity, right.

ACK


https://gerrit.osmocom.org/#/c/13392/7/src/fsm.c
File src/fsm.c:

https://gerrit.osmocom.org/#/c/13392/7/src/fsm.c@105
PS7, Line 105: = {};
I'm not sure you can do this to a __thread variable.  The initializer is likely only applied at compile time and the thread-local copy is generated at runtime? But well, maybe it simply works.  Why do you want to have a {} here anyway? 

As per the ABI spec, all 'static' variables are zero-initialized, always.



-- 
To view, visit https://gerrit.osmocom.org/13392
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eda67540a1cd444491beb7856b9fcd0a3143b18
Gerrit-Change-Number: 13392
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Apr 2019 09:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190409/784080c6/attachment.html>


More information about the gerrit-log mailing list