Change in libosmocore[master]: fsm: support graceful osmo_fsm_inst_term() cascades

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Apr 10 15:50:45 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13392 )

Change subject: fsm: support graceful osmo_fsm_inst_term() cascades
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/13392/7/src/fsm.c
File src/fsm.c:

https://gerrit.osmocom.org/#/c/13392/7/src/fsm.c@105
PS7, Line 105: = {};
> I'm not sure you can do this to a __thread variable. […]
just to be explicit ... because the concept that all static variables are guaranteed to be zero initialized is still new to me and I haven't settled into trusting that yet. I can drop it...

This is the first time I come across __thread, I don't know anything about it.



-- 
To view, visit https://gerrit.osmocom.org/13392
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eda67540a1cd444491beb7856b9fcd0a3143b18
Gerrit-Change-Number: 13392
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Apr 2019 15:50:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190410/941dd056/attachment.html>


More information about the gerrit-log mailing list