Change in osmo-hlr[master]: USSD: fix routing to multiple MSC

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Apr 8 13:32:12 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13479 )

Change subject: USSD: fix routing to multiple MSC
......................................................................


Patch Set 7:

(3 comments)

in general the approach looks good

https://gerrit.osmocom.org/#/c/13479/7/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13479/7/src/hlr_ussd.c@171
PS7, Line 171: vlr_number
> What about static memory allocation? […]
In the current state I would agree, but I know where this is coming from.
In the long run, the aim is to have a blob as VLR identification, a uint8_t* plus an arbitrary len.
But I'm not entirely sure yet that we're approaching the blob plan in the right way.

So, yes, in this patch alone, the most sensible thing would be a vlr_number[32] array,
at least while hlr_subscriber also maintains a char[32] for it.


https://gerrit.osmocom.org/#/c/13479/7/src/hlr_ussd.c@171
PS7, Line 171: vlr_number
> I'm not sure if this is a good idea. I know that db.h has it defined that way. […]
[2] is wrong, will comment over there


https://gerrit.osmocom.org/#/c/13479/7/src/hlr_ussd.c@244
PS7, Line 244: 		ss->vlr_number = talloc_strdup(ss, subscr.vlr_number);
(maybe OSMO_ASSERT(ss->vlr_number) )



-- 
To view, visit https://gerrit.osmocom.org/13479
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18067bfadd33a6bc59a9ee336b6937313826fce3
Gerrit-Change-Number: 13479
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Apr 2019 13:32:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/1f4def92/attachment.html>


More information about the gerrit-log mailing list