Change in osmo-hlr[master]: USSD: fix routing to multiple MSC

osmith gerrit-no-reply at lists.osmocom.org
Mon Apr 8 13:25:29 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13479 )

Change subject: USSD: fix routing to multiple MSC
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13479/4/src/hlr_ussd.c@255
PS4, Line 255: en(ss->vlr_number) + 1, ms
> This must be […]
Patch to avoid this mistake with proper documentation for addr, addrlen:
https://gerrit.osmocom.org/#/c/osmo-hlr/+/13549


https://gerrit.osmocom.org/#/c/13479/7/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/13479/7/src/hlr_ussd.c@171
PS7, Line 171: vlr_number
> What about static memory allocation? […]
I'm not sure if this is a good idea. I know that db.h has it defined that way. But we don't seem to enforce that as max size in the VTY config of OsmoMSC [1]. Follow up patch [2] will save the gsup->source_name as vlr_number, where we also don't enforce that size limit. So we might end up shortening two IPA names that are longer than 32 bytes and cause a collision.

[1]: https://git.osmocom.org/osmo-msc/tree/src/libmsc/msc_vty.c?id=0f52319765e9834095c4774ef6a3b22825fa618c#n1622
[2]: https://gerrit.osmocom.org/#/c/osmo-hlr/+/13515/



-- 
To view, visit https://gerrit.osmocom.org/13479
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18067bfadd33a6bc59a9ee336b6937313826fce3
Gerrit-Change-Number: 13479
Gerrit-PatchSet: 7
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Apr 2019 13:25:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/32332bbf/attachment.html>


More information about the gerrit-log mailing list