Change in osmo-bsc[master]: osmo_bsc_lcls.c: cosmetic: make Coverity happy

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 8 07:30:42 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13533 )

Change subject: osmo_bsc_lcls.c: cosmetic: make Coverity happy
......................................................................

osmo_bsc_lcls.c: cosmetic: make Coverity happy

The 'return' that makes Coverity angry can be safely replaced by 'break'.

Change-Id: Ib3d7519421319fb0e6d65441bba123b7b01f4556
Fixes: CID#188873 Identical code for different branches
Fixes: CID#188850 Identical code for different branches
Fixes: CID#188845 Identical code for different branches
---
M src/osmo-bsc/osmo_bsc_lcls.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c
index c1f62dc..98c74c7 100644
--- a/src/osmo-bsc/osmo_bsc_lcls.c
+++ b/src/osmo-bsc/osmo_bsc_lcls.c
@@ -388,7 +388,7 @@
 	case LCLS_EV_UPDATE_CFG_CSC:
 		if (lcls_handle_cfg_update(conn, data) != 0)
 			return;
-		return;
+		break;
 	case LCLS_EV_APPLY_CFG_CSC:
 		if (conn->lcls.config == GSM0808_LCLS_CFG_NA)
 			return;
@@ -426,7 +426,7 @@
 	case LCLS_EV_UPDATE_CFG_CSC:
 		if (lcls_handle_cfg_update(conn, data) != 0)
 			return;
-		return;
+		break;
 	case LCLS_EV_APPLY_CFG_CSC:
 		if (lcls_enable_possible(conn)) {
 			osmo_fsm_inst_state_chg(fi, ST_LOCALLY_SWITCHED, 0, 0);
@@ -471,7 +471,7 @@
 	case LCLS_EV_UPDATE_CFG_CSC:
 		if (lcls_handle_cfg_update(conn, data) != 0)
 			return;
-		return;
+		break;
 	case LCLS_EV_APPLY_CFG_CSC:
 		if (lcls_perform_correlation(conn) != 0) {
 			/* no correlation result: Remain in NOT_POSSIBLE_LS */

-- 
To view, visit https://gerrit.osmocom.org/13533
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3d7519421319fb0e6d65441bba123b7b01f4556
Gerrit-Change-Number: 13533
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/5e7f0593/attachment.html>


More information about the gerrit-log mailing list