<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13533">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_bsc_lcls.c: cosmetic: make Coverity happy<br><br>The 'return' that makes Coverity angry can be safely replaced by 'break'.<br><br>Change-Id: Ib3d7519421319fb0e6d65441bba123b7b01f4556<br>Fixes: CID#188873 Identical code for different branches<br>Fixes: CID#188850 Identical code for different branches<br>Fixes: CID#188845 Identical code for different branches<br>---<br>M src/osmo-bsc/osmo_bsc_lcls.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c</span><br><span>index c1f62dc..98c74c7 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_lcls.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_lcls.c</span><br><span>@@ -388,7 +388,7 @@</span><br><span>     case LCLS_EV_UPDATE_CFG_CSC:</span><br><span>                 if (lcls_handle_cfg_update(conn, data) != 0)</span><br><span>                         return;</span><br><span style="color: hsl(0, 100%, 40%);">-         return;</span><br><span style="color: hsl(120, 100%, 40%);">+               break;</span><br><span>       case LCLS_EV_APPLY_CFG_CSC:</span><br><span>          if (conn->lcls.config == GSM0808_LCLS_CFG_NA)</span><br><span>                     return;</span><br><span>@@ -426,7 +426,7 @@</span><br><span>        case LCLS_EV_UPDATE_CFG_CSC:</span><br><span>                 if (lcls_handle_cfg_update(conn, data) != 0)</span><br><span>                         return;</span><br><span style="color: hsl(0, 100%, 40%);">-         return;</span><br><span style="color: hsl(120, 100%, 40%);">+               break;</span><br><span>       case LCLS_EV_APPLY_CFG_CSC:</span><br><span>          if (lcls_enable_possible(conn)) {</span><br><span>                    osmo_fsm_inst_state_chg(fi, ST_LOCALLY_SWITCHED, 0, 0);</span><br><span>@@ -471,7 +471,7 @@</span><br><span>        case LCLS_EV_UPDATE_CFG_CSC:</span><br><span>                 if (lcls_handle_cfg_update(conn, data) != 0)</span><br><span>                         return;</span><br><span style="color: hsl(0, 100%, 40%);">-         return;</span><br><span style="color: hsl(120, 100%, 40%);">+               break;</span><br><span>       case LCLS_EV_APPLY_CFG_CSC:</span><br><span>          if (lcls_perform_correlation(conn) != 0) {</span><br><span>                   /* no correlation result: Remain in NOT_POSSIBLE_LS */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13533">change 13533</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13533"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib3d7519421319fb0e6d65441bba123b7b01f4556 </div>
<div style="display:none"> Gerrit-Change-Number: 13533 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>