This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13523 ) Change subject: abis_nm.c: fix broken logging in abis_nm_rx_ipacc() ...................................................................... abis_nm.c: fix broken logging in abis_nm_rx_ipacc() Change-Id: I65ff2968523a90607bafd44e6f4f3d3e29ff73ef --- M src/osmo-bsc/abis_nm.c 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified Pau Espin Pedrol: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 5be207f..240517b 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -2709,11 +2709,12 @@ abis_nm_tlv_parse(&tp, sign_link->trx->bts, foh->data, oh->length-sizeof(*foh)); - DEBUGPFOH(DNM, foh, "IPACCESS(0x%02x): ", foh->msg_type); + DEBUGPFOH(DNM, foh, "Rx IPACCESS(0x%02x): %s\n", foh->msg_type, + osmo_hexdump(foh->data, oh->length - sizeof(*foh))); switch (foh->msg_type) { case NM_MT_IPACC_RSL_CONNECT_ACK: - DEBUGPC(DNM, "RSL CONNECT ACK "); + DEBUGPFOH(DNM, foh, "RSL CONNECT ACK "); if (TLVP_PRESENT(&tp, NM_ATT_IPACC_DST_IP)) { memcpy(&addr, TLVP_VAL(&tp, NM_ATT_IPACC_DST_IP), sizeof(addr)); @@ -2773,7 +2774,7 @@ LOGPC(DNM, LOGL_ERROR, "\n"); break; default: - DEBUGPC(DNM, "unknown\n"); + LOGPFOH(DNM, LOGL_ERROR, foh, "Unknown message\n"); break; } -- To view, visit https://gerrit.osmocom.org/13523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I65ff2968523a90607bafd44e6f4f3d3e29ff73ef Gerrit-Change-Number: 13523 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190406/dbcbc4f4/attachment.htm>