<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13523">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_nm.c: fix broken logging in abis_nm_rx_ipacc()<br><br>Change-Id: I65ff2968523a90607bafd44e6f4f3d3e29ff73ef<br>---<br>M src/osmo-bsc/abis_nm.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index 5be207f..240517b 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -2709,11 +2709,12 @@</span><br><span> </span><br><span>      abis_nm_tlv_parse(&tp, sign_link->trx->bts, foh->data, oh->length-sizeof(*foh));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    DEBUGPFOH(DNM, foh, "IPACCESS(0x%02x): ", foh->msg_type);</span><br><span style="color: hsl(120, 100%, 40%);">+        DEBUGPFOH(DNM, foh, "Rx IPACCESS(0x%02x): %s\n", foh->msg_type,</span><br><span style="color: hsl(120, 100%, 40%);">+            osmo_hexdump(foh->data, oh->length - sizeof(*foh)));</span><br><span> </span><br><span>     switch (foh->msg_type) {</span><br><span>  case NM_MT_IPACC_RSL_CONNECT_ACK:</span><br><span style="color: hsl(0, 100%, 40%);">-               DEBUGPC(DNM, "RSL CONNECT ACK ");</span><br><span style="color: hsl(120, 100%, 40%);">+           DEBUGPFOH(DNM, foh, "RSL CONNECT ACK ");</span><br><span>           if (TLVP_PRESENT(&tp, NM_ATT_IPACC_DST_IP)) {</span><br><span>                    memcpy(&addr,</span><br><span>                            TLVP_VAL(&tp, NM_ATT_IPACC_DST_IP), sizeof(addr));</span><br><span>@@ -2773,7 +2774,7 @@</span><br><span>                       LOGPC(DNM, LOGL_ERROR, "\n");</span><br><span>              break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                DEBUGPC(DNM, "unknown\n");</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGPFOH(DNM, LOGL_ERROR, foh, "Unknown message\n");</span><br><span>                break;</span><br><span>       }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13523">change 13523</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13523"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I65ff2968523a90607bafd44e6f4f3d3e29ff73ef </div>
<div style="display:none"> Gerrit-Change-Number: 13523 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>